Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small improvements on the aggsender #189

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

goran-ethernal
Copy link
Contributor

@goran-ethernal goran-ethernal commented Feb 7, 2025

Description

This PR introduces couple of improvements to the aggsender:

  1. Remove unnecessary SaveCertificatesToFilesPath config parameter, which was used to save certificates we send to the agglayer to some temporary file. Since we are already saving the entire json format to the aggsender db, this became redundant.
  2. Expanded the aggsender.md with new configuration parameters that were added in couple of previous PRs.
  3. Removed the check for pending certificates in the sendCertificate function, since we are already checking this before we make a call to that function.
  4. In the aggchain prover flow, when we are resending the certificate that is InError, we will always make a call to the aggchain prover to get the proof, even though we might have it, because, the previously sent InError certificate might be subject to a reorg, and the previous sent proof might not be valid anymore.
  5. Renamed the AggchainProverMode to the AggchainProofMode to be more consistent.

Fixes # (issue)

@goran-ethernal goran-ethernal marked this pull request as ready for review February 7, 2025 10:00
@goran-ethernal goran-ethernal self-assigned this Feb 7, 2025
@goran-ethernal goran-ethernal merged commit be291b6 into feat/aggchain-prover Feb 7, 2025
11 checks passed
@goran-ethernal goran-ethernal deleted the feat/small-improvements branch February 7, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants